Bug 63587

Summary: Consolidate the fast/loader and fast/loading directories
Product: WebKit Reporter: Darin Adler <darin>
Component: Tools / TestsAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ec2-cr-linux-01
none
Patch for landing none

Darin Adler
Reported 2011-06-28 17:18:29 PDT
Consolidate the fast/loader and fast/loading directories
Attachments
Patch (7.05 KB, patch)
2011-06-28 17:27 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ec2-cr-linux-01 (1.34 MB, application/zip)
2011-06-28 17:48 PDT, WebKit Review Bot 		no flags
Details
Patch for landing (8.24 KB, patch)
2011-06-28 22:32 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2011-06-28 17:27:54 PDT
Created attachment 99006 [details] Patch
WebKit Review Bot
Comment 2 2011-06-28 17:48:44 PDT
Comment on attachment 99006 [details] Patch Attachment 99006 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8948974 New failing tests: fast/loader/subframe-removes-itself.html
WebKit Review Bot
Comment 3 2011-06-28 17:48:49 PDT
Created attachment 99011 [details] Archive of layout-test-results from ec2-cr-linux-01 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-01 Port: Chromium Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Darin Adler
Comment 4 2011-06-28 17:51:50 PDT
Maybe I did not spot the changes needed for Chromium test expectations? Could someone with some Chromium expertise help me out with this?
Adam Barth
Comment 5 2011-06-28 17:58:15 PDT
> Could someone with some Chromium expertise help me out with this? Sure.
Adam Barth
Comment 6 2011-06-28 18:12:33 PDT
Comment on attachment 99006 [details] Patch I didn't see anything obvious, but I'll figure it out and land this patch for you.
Adam Barth
Comment 7 2011-06-28 22:31:42 PDT
The moved test would have failed on all platforms. The old directory apparently used to trigger an implicit call to dumpFrameLoadCallbacks. I've added an explicit call to preserve the intent of the test.
Adam Barth
Comment 8 2011-06-28 22:32:36 PDT
Created attachment 99040 [details] Patch for landing
WebKit Review Bot
Comment 9 2011-06-29 00:12:02 PDT
Comment on attachment 99040 [details] Patch for landing Clearing flags on attachment: 99040 Committed r89994: <http://trac.webkit.org/changeset/89994>
WebKit Review Bot
Comment 10 2011-06-29 00:12:10 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 11 2011-06-29 08:13:28 PDT
(In reply to comment #7) > The moved test would have failed on all platforms. Oh, got it. How could I have missed that?! Thanks very much for taking care of this.
Adam Barth
Comment 12 2011-06-29 08:34:11 PDT
My pleasure.
Note You need to log in before you can comment on or make changes to this bug.