Bug 63530

Summary:

Add a test for canceling selectstart when a word is selected by right click

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

UI Events

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

URL:

http://www.nakedvalue.com/

Bug Depends on:

Bug Blocks:

60424

Attachments:

Description	Flags
adds a regression test	darin: review+

Description Ryosuke Niwa 2011-06-28 06:26:53 PDT

On Safari 5, you can select a word on http://www.nakedvalue.com/ by right clicking even though the page has document.body.onselectstart = function () { return false; }

On ToT WebKit this bug no longer exists.  We should add a test to ensure this does not regress.

Comment 1 Ryosuke Niwa 2011-06-28 08:07:05 PDT

Created attachment 98923 [details]
adds a regression test

Comment 2 Darin Adler 2011-06-28 08:09:13 PDT

Comment on attachment 98923 [details]
adds a regression test

View in context: https://bugs.webkit.org/attachment.cgi?id=98923&action=review

> LayoutTests/fast/events/selectstart-prevent-selection-on-right-click.html:17
> +    document.writeln('This test requires eventSender');

A little strange to use writeln, since it just puts in a newline that will be collapsed out.

Comment 3 Ryosuke Niwa 2011-06-28 08:09:16 PDT

Committed r89929: <http://trac.webkit.org/changeset/89929>

Comment 4 Ryosuke Niwa 2011-06-28 08:10:46 PDT

(In reply to comment #2)
> A little strange to use writeln, since it just puts in a newline that will be collapsed out.

I guess I should be doing #test.textContent = x.  Will fix along and add it to the skipped list of mac-wk2.