Bug 63514

Summary: Fix filesystem_unittest.FileSystemTest test_read_and_write_file()
Product: WebKit Reporter: Roland Steiner <rolandsteiner>
Component: Tools / TestsAssignee: Roland Steiner <rolandsteiner>
Status: RESOLVED FIXED    
Severity: Normal CC: dominicc, dpranke, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 61772, 63419, 63528    
Attachments:
Description Flags
Patch none

Roland Steiner
Reported 2011-06-28 00:02:44 PDT
test_read_and_write_file in the FileSystemTest unit test has 3 bugs: .) any raised exception from assertEquals is swallowed by the 'except' clause .) text/binary_path is not 'None' after mktemp, but os.remove may still raise an exception if no data was actually written to the file .) write_text_file is used instead of write_binary_file to write binary contents (this again was swallowed by 'except')
Attachments
Patch (1.87 KB, patch)
2011-06-28 00:06 PDT, Roland Steiner 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Roland Steiner
Comment 1 2011-06-28 00:06:32 PDT
Created attachment 98868 [details] Patch
WebKit Review Bot
Comment 2 2011-06-28 11:29:30 PDT
Comment on attachment 98868 [details] Patch Clearing flags on attachment: 98868 Committed r89944: <http://trac.webkit.org/changeset/89944>
WebKit Review Bot
Comment 3 2011-06-28 11:29:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.