Bug 63511

Summary: Use RefPtr for the HTMLElement data members of TextFieldInptType and SearchInputType
Product: WebKit Reporter: Kent Tamura <tkent>
Component: FormsAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, morrita, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 61415    
Attachments:
Description Flags
Patch
none
Patch none

Kent Tamura
Reported 2011-06-27 23:07:22 PDT
Use RefPtr for the HTMLElement data members of TextFieldInptType and SearchInputType
Attachments
Patch (12.48 KB, patch)
2011-06-27 23:33 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch (12.67 KB, patch)
2011-06-28 00:43 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2011-06-27 23:33:47 PDT
Created attachment 98865 [details] Patch
Kent Tamura
Comment 2 2011-06-28 00:43:15 PDT
Created attachment 98874 [details] Patch
Hajime Morrita
Comment 3 2011-06-28 01:15:27 PDT
Comment on attachment 98874 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98874&action=review > Source/WebCore/html/TextFieldInputType.cpp:139 > + bool shouldHaveSpinButton = theme->shouldHaveSpinButton(element()); Why do we need this change?
Kent Tamura
Comment 4 2011-06-28 01:18:14 PDT
Comment on attachment 98874 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98874&action=review Thank you for reviewing. >> Source/WebCore/html/TextFieldInputType.cpp:139 >> + bool shouldHaveSpinButton = theme->shouldHaveSpinButton(element()); > > Why do we need this change? RenderTheme::themeForPage() might create a new RenderTheme.
Hajime Morrita
Comment 5 2011-06-28 01:45:05 PDT
> RenderTheme::themeForPage() might create a new RenderTheme. Got it. Thank you for the explanation!
WebKit Review Bot
Comment 6 2011-06-28 02:21:12 PDT
Comment on attachment 98874 [details] Patch Clearing flags on attachment: 98874 Committed r89910: <http://trac.webkit.org/changeset/89910>
WebKit Review Bot
Comment 7 2011-06-28 02:21:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.