Bug 63507

Summary:

webarchive/loading/missing-data.html is failing on Mac

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

WebCore Misc.

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, aroben, darin, sam, zimmermann

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	abarth: review+

Ryosuke Niwa

Reported 2011-06-27 20:34:16 PDT

webarchive/loading/missing-data.html has been failing since http://trac.webkit.org/log/trunk?action=stop_on_copy&mode=stop_on_copy&rev=89742&stop_rev=89736&limit=100&verbose=on according to http://build.webkit.org/TestFailures/#/Leopard Intel Release (Tests)

Attachments
Patch (1.55 KB, patch) 2011-08-03 14:49 PDT, Anders Carlsson	abarth: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2011-06-27 20:34:41 PDT

The test was added by http://trac.webkit.org/changeset/66562.

Ryosuke Niwa

Comment 2 2011-06-27 20:37:10 PDT

Looking at SnowLeopard Intel Leak's failures, it seems like this test was affected by other tests being added to the skipped list: http://trac.webkit.org/log/trunk?action=stop_on_copy&mode=stop_on_copy&rev=89736&stop_rev=89733&limit=100&verbose=on

Adam Roben (:aroben)

Comment 3 2011-07-01 12:28:03 PDT

So what's the right thing to do here? I guess we could try skipping this test, too.

Adam Roben (:aroben)

Comment 4 2011-07-01 12:29:22 PDT

Looks like it's only intermittently failing on Leopard: http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r90229%20(33702)/results.html failed http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r90228%20(33701)/results.html passed http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r90226%20(33700)/results.html failed

Adam Roben (:aroben)

Comment 5 2011-07-01 12:30:48 PDT

(In reply to comment #4) > Looks like it's only intermittently failing on Leopard: > > http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r90229%20(33702)/results.html failed > http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r90228%20(33701)/results.html passed > http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r90226%20(33700)/results.html failed Oh, I'm wrong. Build 33701 didn't complete, but presumably the test would have failed. (I need to teach TestFailures not to get confused by that.)

Anders Carlsson

Comment 6 2011-08-03 14:49:07 PDT

Created attachment 102832 [details] Patch

Adam Barth

Comment 7 2011-08-03 14:50:50 PDT

Comment on attachment 102832 [details] Patch Sorry for breaking this. Moving web archives into documentloader makes infinitely more sense than dealing with them in FrameLoader.

Anders Carlsson

Comment 8 2011-08-03 14:53:21 PDT

Committed r92314: <http://trac.webkit.org/changeset/92314>

Note You need to log in before you can comment on or make changes to this bug.