Summary: | [Chromium] Pass an optional WebNode that is the node receiving the context menu action. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | James Hawkins <jhawkins> | ||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | fishd | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
James Hawkins
2011-06-27 19:01:59 PDT
Created attachment 98843 [details]
Patch
+Darin Comment on attachment 98843 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98843&action=review OK, R=me > Source/WebKit/chromium/src/WebFrameImpl.cpp:1138 > + pluginContainer = pluginContainerFromNode(node); nit: indentation (In reply to comment #3) > (From update of attachment 98843 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=98843&action=review > > OK, R=me > > > Source/WebKit/chromium/src/WebFrameImpl.cpp:1138 > > + pluginContainer = pluginContainerFromNode(node); > > nit: indentation Done. Committed r89939: <http://trac.webkit.org/changeset/89939> Comment on attachment 98843 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98843&action=review > Source/WebKit/chromium/src/WebFrameImpl.cpp:291 > + if (coreNode->hasTagName(HTMLNames::objectTag) || coreNode->hasTagName(HTMLNames::embedTag)) { This call fails with coreNode == 0 in the "Copy" branch. |