Bug 63496

Summary: [Qt] DRT support for setInteractiveFormValidationEnabled
Product: WebKit Reporter: Diego Gonzalez <diegohcg>
Component: Tools / TestsAssignee: Diego Gonzalez <diegohcg>
Status: RESOLVED FIXED    
Severity: Normal CC: ossy, tonikitoo
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kenneth: review+, kenneth: commit-queue-

Description Diego Gonzalez 2011-06-27 17:16:46 PDT
Make possible to enable setInteractiveFormValidationEnabled on Qt DRT

Unskipped:
    fast/forms/interactive-validation-prevented.html
    fast/forms/interactive-validation-attach-assertion.html
    fast/forms/interactive-validation-assertion-by-validate-twice.html
    fast/forms/interactive-validation-select-crash.html
    fast/forms/interactive-validation-crash-by-style-override.html
Comment 1 Diego Gonzalez 2011-06-27 17:20:46 PDT
Created attachment 98821 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2011-06-28 01:43:54 PDT
Comment on attachment 98821 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98821&action=review

> Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:1012
> +void DumpRenderTreeSupportQt::setInteractiveFormValidationEnabled(QWebPage* page, bool flag)

flag is a pretty bad name for a bool. what about 'bool enable'
Comment 3 Diego Gonzalez 2011-06-29 05:32:29 PDT
commited at r89972