Bug 63488

Summary: Stop using deprecated SkDeviceFactory API
Product: WebKit Reporter: Mike Reed <reed>
Component: New BugsAssignee: Mike Reed <reed>
Status: RESOLVED FIXED    
Severity: Normal CC: alokp, bsalomon, jamesr, senorblanco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Mike Reed
Reported 2011-06-27 15:07:28 PDT
Stop using deprecated SkDeviceFactory API
Attachments
Patch (3.38 KB, patch)
2011-06-27 15:08 PDT, Mike Reed 		no flags
DetailsFormatted DiffDiff
Patch (3.38 KB, patch)
2011-07-01 12:02 PDT, Mike Reed 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mike Reed
Comment 1 2011-06-27 15:08:19 PDT
Created attachment 98798 [details] Patch
Eric Seidel (no email)
Comment 2 2011-06-27 15:36:12 PDT
Comment on attachment 98798 [details] Patch LGTM. If you need someone with skia-skills to review, you should seek a second opinion.
Alok Priyadarshi
Comment 3 2011-06-28 08:43:35 PDT
Comment on attachment 98798 [details] Patch lgtm Brian had a patch to fix this too - https://bugs.webkit.org/show_bug.cgi?id=62995
Brian Salomon
Comment 4 2011-06-30 06:47:47 PDT
LGTM (unofficial), I will close https://bugs.webkit.org/show_bug.cgi?id=62995.
Brian Salomon
Comment 5 2011-07-01 08:04:08 PDT
*** Bug 62995 has been marked as a duplicate of this bug. ***
Mike Reed
Comment 6 2011-07-01 12:02:59 PDT
Created attachment 99498 [details] Patch
Mike Reed
Comment 7 2011-07-01 12:03:18 PDT
rebaselined. no code changes
James Robinson
Comment 8 2011-07-01 12:16:41 PDT
Comment on attachment 99498 [details] Patch OK
WebKit Review Bot
Comment 9 2011-07-01 13:28:00 PDT
Comment on attachment 99498 [details] Patch Clearing flags on attachment: 99498 Committed r90270: <http://trac.webkit.org/changeset/90270>
WebKit Review Bot
Comment 10 2011-07-01 13:28:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.