63488 – Stop using deprecated SkDeviceFactory API

Bug 63488 - Stop using deprecated SkDeviceFactory API

Summary: Stop using deprecated SkDeviceFactory API

Attachments
Patch (3.38 KB, patch) 2011-06-27 15:08 PDT, Mike Reed	no flags	Details \| Formatted Diff \| Diff
Patch (3.38 KB, patch) 2011-07-01 12:02 PDT, Mike Reed	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Mike Reed 2011-06-27 15:07:28 PDT

Stop using deprecated SkDeviceFactory API

Comment 1 Mike Reed 2011-06-27 15:08:19 PDT

Created attachment 98798 [details]
Patch

Comment 2 Eric Seidel (no email) 2011-06-27 15:36:12 PDT

Comment on attachment 98798 [details]
Patch

LGTM.  If you need someone with skia-skills to review, you should seek a second opinion.

Comment 3 Alok Priyadarshi 2011-06-28 08:43:35 PDT

Comment on attachment 98798 [details]
Patch

lgtm

Brian had a patch to fix this too - https://bugs.webkit.org/show_bug.cgi?id=62995

Comment 4 Brian Salomon 2011-06-30 06:47:47 PDT

LGTM (unofficial), I will close https://bugs.webkit.org/show_bug.cgi?id=62995.

Comment 5 Brian Salomon 2011-07-01 08:04:08 PDT

*** Bug 62995 has been marked as a duplicate of this bug. ***

Comment 6 Mike Reed 2011-07-01 12:02:59 PDT

Created attachment 99498 [details]
Patch

Comment 7 Mike Reed 2011-07-01 12:03:18 PDT

rebaselined. no code changes

Comment 8 James Robinson 2011-07-01 12:16:41 PDT

Comment on attachment 99498 [details]
Patch

OK

Comment 9 WebKit Review Bot 2011-07-01 13:28:00 PDT

Comment on attachment 99498 [details]
Patch

Clearing flags on attachment: 99498

Committed r90270: <http://trac.webkit.org/changeset/90270>

Comment 10 WebKit Review Bot 2011-07-01 13:28:04 PDT

All reviewed patches have been landed.  Closing bug.