Summary: | Extract LineBreakIteratorPool class into its own file | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | darin, joepeck, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Joseph Pecoraro
2011-06-27 12:05:59 PDT
Created attachment 98763 [details]
[PATCH] Add LineBreakIteratorPoolICU.h
I added it to all the builds that I saw had TextBreakIteratorICU.h
Attachment 98763 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/text/TextBreakIteratorICU.cpp:26: Alphabetical sorting problem. [build/include_order] [4]
Source/WebCore/WebCore.vcproj/WebCore.vcproj:31534: mismatched tag [xml/syntax] [5]
Total errors found: 2 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 98763 [details] [PATCH] Add LineBreakIteratorPoolICU.h View in context: https://bugs.webkit.org/attachment.cgi?id=98763&action=review >> Source/WebCore/platform/text/TextBreakIteratorICU.cpp:26 >> +#include "LineBreakIteratorPoolICU.h" > > Alphabetical sorting problem. [build/include_order] [4] Whoops, twice in one week... Will fix with other review comments / before landing. Comment on attachment 98763 [details] [PATCH] Add LineBreakIteratorPoolICU.h View in context: https://bugs.webkit.org/attachment.cgi?id=98763&action=review > Source/WebCore/platform/text/LineBreakIteratorPoolICU.h:2 > + * Copyright (C) 2006 Lars Knoll <lars@trolltech.com> Lars shouldn’t get copyright for this new code. > Source/WebCore/platform/text/LineBreakIteratorPoolICU.h:3 > + * Copyright (C) 2007 Apple Inc. All rights reserved. The code you put into this file is all new. The copyright should be 2011, not 2007. > Source/WebCore/platform/text/LineBreakIteratorPoolICU.h:34 > +WTF_MAKE_NONCOPYABLE(LineBreakIteratorPool); I think this should be indented. (In reply to comment #4) > (From update of attachment 98763 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=98763&action=review > > > Source/WebCore/platform/text/LineBreakIteratorPoolICU.h:2 > > + * Copyright (C) 2006 Lars Knoll <lars@trolltech.com> > > Lars shouldn’t get copyright for this new code. > > > Source/WebCore/platform/text/LineBreakIteratorPoolICU.h:3 > > + * Copyright (C) 2007 Apple Inc. All rights reserved. > > The code you put into this file is all new. The copyright should be 2011, not 2007. Wow, I didn't realize how new it was! That sounds good. http://trac.webkit.org/changeset/89592 > > Source/WebCore/platform/text/LineBreakIteratorPoolICU.h:34 > > +WTF_MAKE_NONCOPYABLE(LineBreakIteratorPool); > > I think this should be indented. Okay, will fix. Landed in r89851: <http://trac.webkit.org/changeset/89851>. |