Summary: | Web Inspector: create status bar buttons programmatically. Add "Inspect" button to all panels. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Pavel Feldman <pfeldman> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Pavel Feldman
2011-06-27 06:37:13 PDT
Created attachment 98715 [details]
Patch
Created attachment 98726 [details]
Patch
Comment on attachment 98726 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98726&action=review > Source/WebCore/inspector/front-end/inspector.js:189 > + anchoredStatusBar.appendChild(this.panels.elements.nodeSearchButton.element); There is no Elements panel in worker inspector window, please add a check. > Source/WebCore/inspector/front-end/inspector.js:210 > + this._dockToggleButton.title = WebInspector.UIString("Undock into separate window."); Would be nice to have a toggle button that would automatically switch between two titles. Created attachment 98930 [details]
Patch
Comment on attachment 98930 [details] Patch Clearing flags on attachment: 98930 Committed r90014: <http://trac.webkit.org/changeset/90014> All reviewed patches have been landed. Closing bug. |