Summary: | Web Inspector: Change the inspector model API and backend to allow CSS pseudoclass inspection | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexander Pavlov (apavlov) <apavlov> | ||||
Component: | Web Inspector (Deprecated) | Assignee: | Alexander Pavlov (apavlov) <apavlov> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | 63461 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Alexander Pavlov (apavlov)
2011-06-27 06:14:12 PDT
Created attachment 98729 [details]
[PATCH] Suggested solution
Attachment 98729 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/insp..." exit_code: 1
Source/WebCore/inspector/InspectorCSSAgent.cpp:214: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorCSSAgent.h:64: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5]
Total errors found: 2 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/inspector/styles/get-set-stylesheet-text.html M LayoutTests/inspector/styles/styles-new-API.html M LayoutTests/inspector/styles/styles-source-offsets.html M Source/WebCore/ChangeLog M Source/WebCore/inspector/Inspector.json M Source/WebCore/inspector/InspectorCSSAgent.cpp M Source/WebCore/inspector/InspectorCSSAgent.h M Source/WebCore/inspector/front-end/AuditRules.js M Source/WebCore/inspector/front-end/CSSStyleModel.js M Source/WebCore/inspector/front-end/StylesSidebarPane.js Committed r89822 Manually committed with the style fixed: <http://trac.webkit.org/changeset/89822> Rolled out due to the builds breakage Committed r89922: <http://trac.webkit.org/changeset/89922> |