Bug 63446 – Web Inspector: Change the inspector model API and backend to allow CSS pseudoclass inspection

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Alexander Pavlov (apavlov)]

Patch to follow

[Alexander Pavlov (apavlov)]

Created attachment 98729 [details]
[PATCH] Suggested solution

[WebKit Review Bot]

Attachment 98729 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/insp..." exit_code: 1

Source/WebCore/inspector/InspectorCSSAgent.cpp:214:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorCSSAgent.h:64:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 2 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alexander Pavlov (apavlov)]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
        M       LayoutTests/ChangeLog
        M       LayoutTests/inspector/styles/get-set-stylesheet-text.html
        M       LayoutTests/inspector/styles/styles-new-API.html
        M       LayoutTests/inspector/styles/styles-source-offsets.html
        M       Source/WebCore/ChangeLog
        M       Source/WebCore/inspector/Inspector.json
        M       Source/WebCore/inspector/InspectorCSSAgent.cpp
        M       Source/WebCore/inspector/InspectorCSSAgent.h
        M       Source/WebCore/inspector/front-end/AuditRules.js
        M       Source/WebCore/inspector/front-end/CSSStyleModel.js
        M       Source/WebCore/inspector/front-end/StylesSidebarPane.js
Committed r89822

Manually committed with the style fixed: <http://trac.webkit.org/changeset/89822>

[Alexander Pavlov (apavlov)]

Rolled out due to the builds breakage

[Alexander Pavlov (apavlov)]

Committed r89922: <http://trac.webkit.org/changeset/89922>