Bug 63446 - Web Inspector: Change the inspector model API and backend to allow CSS pseudoclass inspection
: Web Inspector: Change the inspector model API and backend to allow CSS pseudo...
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated)
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To: Alexander Pavlov (apavlov)
:
Depends on: 63461
Blocks:
  Show dependency treegraph
 
Reported: 2011-06-27 06:14 PDT by Alexander Pavlov (apavlov)
Modified: 2011-06-28 05:28 PDT (History)
11 users (show)

See Also:


Attachments
[PATCH] Suggested solution (12.03 KB, patch)
2011-06-27 08:16 PDT, Alexander Pavlov (apavlov)
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Pavlov (apavlov) 2011-06-27 06:14:12 PDT
Patch to follow
Comment 1 Alexander Pavlov (apavlov) 2011-06-27 08:16:28 PDT
Created attachment 98729 [details]
[PATCH] Suggested solution
Comment 2 WebKit Review Bot 2011-06-27 08:19:43 PDT
Attachment 98729 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/insp..." exit_code: 1

Source/WebCore/inspector/InspectorCSSAgent.cpp:214:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorCSSAgent.h:64:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 2 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alexander Pavlov (apavlov) 2011-06-27 08:36:01 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
        M       LayoutTests/ChangeLog
        M       LayoutTests/inspector/styles/get-set-stylesheet-text.html
        M       LayoutTests/inspector/styles/styles-new-API.html
        M       LayoutTests/inspector/styles/styles-source-offsets.html
        M       Source/WebCore/ChangeLog
        M       Source/WebCore/inspector/Inspector.json
        M       Source/WebCore/inspector/InspectorCSSAgent.cpp
        M       Source/WebCore/inspector/InspectorCSSAgent.h
        M       Source/WebCore/inspector/front-end/AuditRules.js
        M       Source/WebCore/inspector/front-end/CSSStyleModel.js
        M       Source/WebCore/inspector/front-end/StylesSidebarPane.js
Committed r89822

Manually committed with the style fixed: <http://trac.webkit.org/changeset/89822>
Comment 4 Alexander Pavlov (apavlov) 2011-06-28 01:21:19 PDT
Rolled out due to the builds breakage
Comment 5 Alexander Pavlov (apavlov) 2011-06-28 05:28:12 PDT
Committed r89922: <http://trac.webkit.org/changeset/89922>