| Summary: | Remove LegacyDefaultOptionalArguments from WebAudio IDL files | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||
| Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | crogers, eric, pilgrim, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Adam Barth
2011-06-26 20:17:33 PDT
Created attachment 98657 [details]
Patch
Are there any tests for WebAudio? I didn't see any in the LayoutTests directory. They're coming soon. 90% of the work has been finished for DRT and run-webkit-tests. I have seven tests ready to go - more to follow. > They're coming soon. 90% of the work has been finished for DRT and run-webkit-tests. I have seven tests ready to go - more to follow.
How does this patch look to you? (I'm happy to add tests for this change once there are some tests to use as templates.)
Looking over this it seems fine. I'll keep an eye out in the next day or so after landing just to be sure that everthing is ok. Concerning:
// FIXME: Why does this method need to be Custom?
[Custom] void connect(in AudioNode destination, in [Optional] unsigned long output, in [Optional] unsigned long input)
raises(DOMException);
When this was originally landed, either the IDL generation didn't support the optional arguments, or I didn't know about it :)
This is an important method, so we'll have to be careful to test it correctly before removing the custom bindings.
Yep, which is why I didn't make the change in this patch :) Comment on attachment 98657 [details]
Patch
OK.
Comment on attachment 98657 [details] Patch Clearing flags on attachment: 98657 Committed r89789: <http://trac.webkit.org/changeset/89789> All reviewed patches have been landed. Closing bug. |