Bug 63416

Summary: Remove LegacyDefaultOptionalArguments from WebAudio IDL files
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: crogers, eric, pilgrim, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2011-06-26 20:17:33 PDT
Remove LegacyDefaultOptionalArguments from WebAudio IDL files
Attachments
Patch (7.59 KB, patch)
2011-06-26 20:20 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-06-26 20:20:54 PDT
Created attachment 98657 [details] Patch
Adam Barth
Comment 2 2011-06-26 20:22:04 PDT
Are there any tests for WebAudio? I didn't see any in the LayoutTests directory.
Chris Rogers
Comment 3 2011-06-26 21:07:32 PDT
They're coming soon. 90% of the work has been finished for DRT and run-webkit-tests. I have seven tests ready to go - more to follow.
Adam Barth
Comment 4 2011-06-26 21:11:14 PDT
> They're coming soon. 90% of the work has been finished for DRT and run-webkit-tests. I have seven tests ready to go - more to follow. How does this patch look to you? (I'm happy to add tests for this change once there are some tests to use as templates.)
Chris Rogers
Comment 5 2011-06-26 21:43:17 PDT
Looking over this it seems fine. I'll keep an eye out in the next day or so after landing just to be sure that everthing is ok.
Chris Rogers
Comment 6 2011-06-26 21:52:16 PDT
Concerning: // FIXME: Why does this method need to be Custom? [Custom] void connect(in AudioNode destination, in [Optional] unsigned long output, in [Optional] unsigned long input) raises(DOMException); When this was originally landed, either the IDL generation didn't support the optional arguments, or I didn't know about it :) This is an important method, so we'll have to be careful to test it correctly before removing the custom bindings.
Adam Barth
Comment 7 2011-06-26 22:09:53 PDT
Yep, which is why I didn't make the change in this patch :)
Eric Seidel (no email)
Comment 8 2011-06-26 23:04:47 PDT
Comment on attachment 98657 [details] Patch OK.
WebKit Review Bot
Comment 9 2011-06-26 23:49:29 PDT
Comment on attachment 98657 [details] Patch Clearing flags on attachment: 98657 Committed r89789: <http://trac.webkit.org/changeset/89789>
WebKit Review Bot
Comment 10 2011-06-26 23:49:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.