Bug 6341

Summary:

Move frame traversal logic from WebFrame to WebBridge

Product:

WebKit

Reporter:

Maciej Stachowiak <mjs>

Component:

WebKit API

Assignee:

Maciej Stachowiak <mjs>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
the patch	eric: review+

Description Maciej Stachowiak 2006-01-02 20:18:34 PST

Now that frame traversal is cleanly factored out, it should be moved over to WebBridge. This lays the 
groundwork to start moving code en masse over the bridge into WebCore.

Comment 1 Maciej Stachowiak 2006-01-02 20:21:07 PST

Created attachment 5434 [details]
the patch

Comment 2 Eric Seidel (no email) 2006-01-02 20:55:26 PST

Comment on attachment 5434 [details]
the patch

Looks sane to me.

I saw one tab in:
+- (WebBridge *)traverseNextFrameStayWithin:(WebBridge *)stayWithin

Also, incidentally, I hate variable names like "fv" if you share my hatred you
could consider making those more legible as you update/move that code.

Finally I asked you over IRC if there were any leaks... which it seems there
were not.

r=me.