Bug 6341 - Move frame traversal logic from WebFrame to WebBridge
Summary: Move frame traversal logic from WebFrame to WebBridge
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Maciej Stachowiak
Depends on:
Reported: 2006-01-02 20:18 PST by Maciej Stachowiak
Modified: 2006-01-02 21:13 PST (History)
0 users

See Also:

the patch (19.87 KB, patch)
2006-01-02 20:21 PST, Maciej Stachowiak
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2006-01-02 20:18:34 PST
Now that frame traversal is cleanly factored out, it should be moved over to WebBridge. This lays the 
groundwork to start moving code en masse over the bridge into WebCore.
Comment 1 Maciej Stachowiak 2006-01-02 20:21:07 PST
Created attachment 5434 [details]
the patch
Comment 2 Eric Seidel (no email) 2006-01-02 20:55:26 PST
Comment on attachment 5434 [details]
the patch

Looks sane to me.

I saw one tab in:
+- (WebBridge *)traverseNextFrameStayWithin:(WebBridge *)stayWithin

Also, incidentally, I hate variable names like "fv" if you share my hatred you
could consider making those more legible as you update/move that code.

Finally I asked you over IRC if there were any leaks... which it seems there
were not.