Summary: | add flexbox and inline-flexbox as possible CSS display values | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tony Chang <tony> | ||||||
Component: | New Bugs | Assignee: | Tony Chang <tony> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | eric, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 62048 | ||||||||
Attachments: |
|
Description
Tony Chang
2011-06-24 15:41:46 PDT
Created attachment 98554 [details]
Patch
Comment on attachment 98554 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98554&action=review > LayoutTests/css3/flexbox/script-tests/display-property.js:6 > +function testFlex(displayValue) > +{ > + return div.style[styleAttribute]; > +} Unused. > LayoutTests/css3/flexbox/script-tests/display-property.js:11 > +div.style.display = '-webkit-flexbox'; > +shouldBeEqualToString('div.style.display', '-webkit-flexbox'); You could move this into testFlex. > Source/WebCore/css/CSSParser.cpp:972 > + // table-column-group | table-column | table-cell | table-caption | -webkit-box | -webkit-inline-box | none | inherit Should this include -webkit-flexbox and -webkit-inline-flexbox? Not really sure this comment is useful though. Created attachment 98556 [details]
Patch for landing
Comment on attachment 98556 [details] Patch for landing Clearing flags on attachment: 98556 Committed r89712: <http://trac.webkit.org/changeset/89712> All reviewed patches have been landed. Closing bug. |