Bug 63361 – add flexbox and inline-flexbox as possible CSS display values

• Component: New Bugs
• Status: RESOLVED FIXED

[Tony Chang]

add flexbox and inline-flexbox as possible CSS display values

[Tony Chang]

Created attachment 98554 [details]
Patch

[Ojan Vafai]

Comment on attachment 98554 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98554&action=review

> LayoutTests/css3/flexbox/script-tests/display-property.js:6
> +function testFlex(displayValue)
> +{
> +    return div.style[styleAttribute];
> +}

Unused.

> LayoutTests/css3/flexbox/script-tests/display-property.js:11
> +div.style.display = '-webkit-flexbox';
> +shouldBeEqualToString('div.style.display', '-webkit-flexbox');

You could move this into testFlex.

> Source/WebCore/css/CSSParser.cpp:972
> +        // table-column-group | table-column | table-cell | table-caption | -webkit-box | -webkit-inline-box | none | inherit

Should this include -webkit-flexbox and -webkit-inline-flexbox?

Not really sure this comment is useful though.

[Tony Chang]

Created attachment 98556 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 98556 [details]
Patch for landing

Clearing flags on attachment: 98556

Committed r89712: <http://trac.webkit.org/changeset/89712>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.