| Summary: | Bugs filed from TestFailures page should include links to Trac for suspect revisions | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ddkilzer | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| URL: | http://build.webkit.org/TestFailures/ | ||||||
| Attachments: |
|
||||||
|
Description
Adam Roben (:aroben)
2011-06-24 13:30:31 PDT
Created attachment 98529 [details]
Include links to Trac in bugs filed from TestFailures
Comment on attachment 98529 [details] Include links to Trac in bugs filed from TestFailures View in context: https://bugs.webkit.org/attachment.cgi?id=98529&action=review r=me > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:309 > + endOfFirstSentence += ' in r' + firstSuspectRevision + ' <' + this._trac.changesetURL(firstSuspectRevision) + '>'; Nit: I like revision links to include the "r", but maybe that's more trouble than it's worth. Comment on attachment 98529 [details] Include links to Trac in bugs filed from TestFailures View in context: https://bugs.webkit.org/attachment.cgi?id=98529&action=review >> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:309 >> + endOfFirstSentence += ' in r' + firstSuspectRevision + ' <' + this._trac.changesetURL(firstSuspectRevision) + '>'; > > Nit: I like revision links to include the "r", but maybe that's more trouble than it's worth. I'm not sure what you mean? This is just putting the URL into the description after the revision number. Something like: foo/bar/baz.html started failing on Windows 7 Release (Tests) in r12345 <http://trac.webkit.org/changeset/12345>. (In reply to comment #3) > (From update of attachment 98529 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=98529&action=review > > >> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:309 > >> + endOfFirstSentence += ' in r' + firstSuspectRevision + ' <' + this._trac.changesetURL(firstSuspectRevision) + '>'; > > > > Nit: I like revision links to include the "r", but maybe that's more trouble than it's worth. > > I'm not sure what you mean? This is just putting the URL into the description after the revision number. Something like: > > foo/bar/baz.html started failing on Windows 7 Release (Tests) in r12345 <http://trac.webkit.org/changeset/12345>. Sorry, I thought it was doing something like this: r<a href="http://trac.webkit.org/changeset/12345">12345</a> That's fine. Committed r89701: <http://trac.webkit.org/changeset/89701> |