Bug 63341

Summary: Pass Strings by const reference to functions
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, darin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Tony Chang
Reported 2011-06-24 12:27:32 PDT
Pass Strings by const reference to functions
Attachments
Patch (14.47 KB, patch)
2011-06-24 12:29 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2011-06-24 12:29:31 PDT
Created attachment 98524 [details] Patch
Tony Chang
Comment 2 2011-06-24 12:30:58 PDT
This is the last patch for fixing passing String by value in WebCore. The only trickiness is in FrameLoader.cpp.
WebKit Review Bot
Comment 3 2011-06-24 15:05:30 PDT
Comment on attachment 98524 [details] Patch Clearing flags on attachment: 98524 Committed r89707: <http://trac.webkit.org/changeset/89707>
WebKit Review Bot
Comment 4 2011-06-24 15:05:34 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 5 2011-06-24 17:12:06 PDT
This broke the Windows build since String::charactersWithNullTermination is a non-const function.
Darin Adler
Comment 6 2011-06-24 17:13:58 PDT
I tried to fix that in <http://trac.webkit.org/changeset/89717>.
Tony Chang
Comment 7 2011-06-27 09:43:03 PDT
(In reply to comment #6) > I tried to fix that in <http://trac.webkit.org/changeset/89717>. Sorry. Thanks for fixing!
Note You need to log in before you can comment on or make changes to this bug.