Bug 63341

Summary:

Pass Strings by const reference to functions

Product:

WebKit

Reporter:

Tony Chang <tony>

Component:

New Bugs

Assignee:

Tony Chang <tony>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, darin, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Tony Chang 2011-06-24 12:27:32 PDT

Pass Strings by const reference to functions

Comment 1 Tony Chang 2011-06-24 12:29:31 PDT

Created attachment 98524 [details]
Patch

Comment 2 Tony Chang 2011-06-24 12:30:58 PDT

This is the last patch for fixing passing String by value in WebCore.  The only trickiness is in FrameLoader.cpp.

Comment 3 WebKit Review Bot 2011-06-24 15:05:30 PDT

Comment on attachment 98524 [details]
Patch

Clearing flags on attachment: 98524

Committed r89707: <http://trac.webkit.org/changeset/89707>

Comment 4 WebKit Review Bot 2011-06-24 15:05:34 PDT

All reviewed patches have been landed.  Closing bug.

Comment 5 Darin Adler 2011-06-24 17:12:06 PDT

This broke the Windows build since String::charactersWithNullTermination is a non-const function.

Comment 6 Darin Adler 2011-06-24 17:13:58 PDT

I tried to fix that in <http://trac.webkit.org/changeset/89717>.

Comment 7 Tony Chang 2011-06-27 09:43:03 PDT

(In reply to comment #6)
> I tried to fix that in <http://trac.webkit.org/changeset/89717>.

Sorry.  Thanks for fixing!