Bug 63293

Summary: convert editing/deleting/5390681-2.html to dump-as-markup
Product: WebKit Reporter: Wyatt Carss <wcarss>
Component: HTML EditingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement CC: jparent, ojan, rniwa, tony, wcarss, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Wyatt Carss
Reported 2011-06-23 14:46:43 PDT
convert editing/deleting/5390681-2.html to dump-as-markup
Attachments
Patch (93.94 KB, patch)
2011-06-23 14:48 PDT, Wyatt Carss 		no flags
DetailsFormatted DiffDiff
Patch (16.99 KB, patch)
2011-06-23 16:11 PDT, Wyatt Carss 		no flags
DetailsFormatted DiffDiff
Patch (17.38 KB, patch)
2011-06-23 18:50 PDT, Wyatt Carss 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Wyatt Carss
Comment 1 2011-06-23 14:48:42 PDT
Created attachment 98410 [details] Patch
Ryosuke Niwa
Comment 2 2011-06-23 14:54:54 PDT
Comment on attachment 98410 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98410&action=review > LayoutTests/ChangeLog:14 > + * editing/deleting/5390681-2.html: > + * editing/deleting/5390681.html: Please rename these files. > LayoutTests/editing/deleting/5390681-2.html:4 > +<p id="description">This tests for a bug where expansion for smart delete would not consider editable boundaries. Only 'foo' should be deleted. You should see ' bar'. <b>There is a bug: while the non-editable space isn't deleted, deletion inserts a placeholder when it shouldn't.</b></p> Clearly, we're not inserting a placeholder anymore. We should probably remove that sentence. r- due to this description.
Wyatt Carss
Comment 3 2011-06-23 16:11:06 PDT
Created attachment 98427 [details] Patch
Ryosuke Niwa
Comment 4 2011-06-23 16:55:19 PDT
Comment on attachment 98427 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98427&action=review > LayoutTests/editing/deleting/smart-delete-across-editable-boundaries-2.html:4 > +<p id="description">This tests for a bug where expansion for smart delete would not consider editable boundaries. Only 'foo' should be deleted. You should see ' bar'. radr id: 5390681</p> You should use the format <rdar://problem/5390681>. > LayoutTests/editing/deleting/smart-delete-across-editable-boundaries.html:12 > +Markup.description("This tests for a bug where expansion for smart delete would not consider editable boundaries. Only 'foo' should be deleted. You should see ' bar'. radr id: 5390681"); Ditto about the rdar id.
Wyatt Carss
Comment 5 2011-06-23 18:50:40 PDT
Created attachment 98451 [details] Patch
Eric Seidel (no email)
Comment 6 2011-09-12 15:48:31 PDT
Comment on attachment 98451 [details] Patch LGTM.
WebKit Review Bot
Comment 7 2011-09-12 20:12:42 PDT
Comment on attachment 98451 [details] Patch Clearing flags on attachment: 98451 Committed r95003: <http://trac.webkit.org/changeset/95003>
WebKit Review Bot
Comment 8 2011-09-12 20:12:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.