| Summary: | convert editing/deleting/5390681-2.html to dump-as-markup | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wyatt Carss <wcarss> | ||||||||
| Component: | HTML Editing | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Enhancement | CC: | jparent, ojan, rniwa, tony, wcarss, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Wyatt Carss
2011-06-23 14:46:43 PDT
Created attachment 98410 [details]
Patch
Comment on attachment 98410 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98410&action=review > LayoutTests/ChangeLog:14 > + * editing/deleting/5390681-2.html: > + * editing/deleting/5390681.html: Please rename these files. > LayoutTests/editing/deleting/5390681-2.html:4 > +<p id="description">This tests for a bug where expansion for smart delete would not consider editable boundaries. Only 'foo' should be deleted. You should see ' bar'. <b>There is a bug: while the non-editable space isn't deleted, deletion inserts a placeholder when it shouldn't.</b></p> Clearly, we're not inserting a placeholder anymore. We should probably remove that sentence. r- due to this description. Created attachment 98427 [details]
Patch
Comment on attachment 98427 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98427&action=review > LayoutTests/editing/deleting/smart-delete-across-editable-boundaries-2.html:4 > +<p id="description">This tests for a bug where expansion for smart delete would not consider editable boundaries. Only 'foo' should be deleted. You should see ' bar'. radr id: 5390681</p> You should use the format <rdar://problem/5390681>. > LayoutTests/editing/deleting/smart-delete-across-editable-boundaries.html:12 > +Markup.description("This tests for a bug where expansion for smart delete would not consider editable boundaries. Only 'foo' should be deleted. You should see ' bar'. radr id: 5390681"); Ditto about the rdar id. Created attachment 98451 [details]
Patch
Comment on attachment 98451 [details]
Patch
LGTM.
Comment on attachment 98451 [details] Patch Clearing flags on attachment: 98451 Committed r95003: <http://trac.webkit.org/changeset/95003> All reviewed patches have been landed. Closing bug. |