Bug 63291

Summary: Add the ability to dynamically modify linked call sites
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch barraclough: review+

Oliver Hunt
Reported 2011-06-23 14:39:52 PDT
Add the ability to dynamically modify linked call sites
Attachments
Patch (29.94 KB, patch)
2011-06-23 15:01 PDT, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch (30.16 KB, patch)
2011-06-23 15:13 PDT, Oliver Hunt 		barraclough: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2011-06-23 15:01:04 PDT
Created attachment 98412 [details] Patch
Gavin Barraclough
Comment 2 2011-06-23 15:10:51 PDT
Comment on attachment 98412 [details] Patch The armv7 code is all wrong. I knows this because oliver says this. he also said a naughty word.
Oliver Hunt
Comment 3 2011-06-23 15:13:15 PDT
Created attachment 98416 [details] Patch
Gavin Barraclough
Comment 4 2011-06-23 15:28:00 PDT
Comment on attachment 98416 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98416&action=review > Source/JavaScriptCore/jit/JITWriteBarrier.h:41 > +#define JITWriteBarrierFlag ((void*)2) Per coding standard I guess this should really be a static_cast, though I'm not sure that really improves anything in this case.
Oliver Hunt
Comment 5 2011-06-23 15:53:55 PDT
Committed r89630: <http://trac.webkit.org/changeset/89630>
Note You need to log in before you can comment on or make changes to this bug.