Bug 63291 - Add the ability to dynamically modify linked call sites
Summary: Add the ability to dynamically modify linked call sites
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-23 14:39 PDT by Oliver Hunt
Modified: 2011-06-23 15:53 PDT (History)
0 users

See Also:

Attachments
Patch (29.94 KB, patch)
2011-06-23 15:01 PDT, Oliver Hunt 		no flags Details | Formatted Diff | Diff
Patch (30.16 KB, patch)
2011-06-23 15:13 PDT, Oliver Hunt 		barraclough: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2011-06-23 14:39:52 PDT 
Add the ability to dynamically modify linked call sites
Comment 1 Oliver Hunt 2011-06-23 15:01:04 PDT 
Created attachment 98412 [details]
Patch
Comment 2 Gavin Barraclough 2011-06-23 15:10:51 PDT 
Comment on attachment 98412 [details]
Patch

The armv7 code is all wrong.  I knows this because oliver says this. he also said a naughty word.
Comment 3 Oliver Hunt 2011-06-23 15:13:15 PDT 
Created attachment 98416 [details]
Patch
Comment 4 Gavin Barraclough 2011-06-23 15:28:00 PDT 
Comment on attachment 98416 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98416&action=review

> Source/JavaScriptCore/jit/JITWriteBarrier.h:41
> +#define JITWriteBarrierFlag ((void*)2)

Per coding standard I guess this should really be a static_cast, though I'm not sure that really improves anything in this case.
Comment 5 Oliver Hunt 2011-06-23 15:53:55 PDT 
Committed r89630: <http://trac.webkit.org/changeset/89630>