Bug 63278

Summary: add test expectation fast/canvas/canvas-large-dimensions.html for new assert in command buffer.
Product: WebKit Reporter: Gregg Tavares <gman>
Component: WebGLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: kbr, webkit.review.bot, zmo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Gregg Tavares
Reported 2011-06-23 13:16:05 PDT
In a future CL I've added asserts for calling glDeleteXXX with id = 0. This is the only layout_test so far that fails this assert.
Attachments
Patch (1.37 KB, patch)
2011-06-23 14:11 PDT, Gregg Tavares 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2011-06-23 13:17:21 PDT
What test are you referring to? Could you please update the synopsis of the bug to be more specific?
Gregg Tavares
Comment 2 2011-06-23 13:54:44 PDT
done. but wouldn't you see the test in the patch once I add the patch?
Gregg Tavares
Comment 3 2011-06-23 14:11:38 PDT
Created attachment 98398 [details] Patch
Kenneth Russell
Comment 4 2011-06-23 14:14:12 PDT
(In reply to comment #2) > done. > > but wouldn't you see the test in the patch once I add the patch? Sorry; yes, but in isolation this bug report was unclear. At minimum I would have mentioned the specific test in the bug description if not the title.
Kenneth Russell
Comment 5 2011-06-23 14:15:59 PDT
Comment on attachment 98398 [details] Patch Looks fine. Do you want this submitted to the commit queue?
WebKit Review Bot
Comment 6 2011-06-23 15:19:33 PDT
Comment on attachment 98398 [details] Patch Clearing flags on attachment: 98398 Committed r89626: <http://trac.webkit.org/changeset/89626>
WebKit Review Bot
Comment 7 2011-06-23 15:19:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.