Bug 63278 - add test expectation fast/canvas/canvas-large-dimensions.html for new assert in command buffer.
Summary: add test expectation fast/canvas/canvas-large-dimensions.html for new assert ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-23 13:16 PDT by Gregg Tavares
Modified: 2011-06-23 15:19 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.37 KB, patch)
2011-06-23 14:11 PDT, Gregg Tavares 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gregg Tavares 2011-06-23 13:16:05 PDT 
In a future CL I've added asserts for calling glDeleteXXX with id = 0. 
This is the only layout_test so far that fails this assert.
Comment 1 Kenneth Russell 2011-06-23 13:17:21 PDT 
What test are you referring to? Could you please update the synopsis of the bug to be more specific?
Comment 2 Gregg Tavares 2011-06-23 13:54:44 PDT 
done.

but wouldn't you see the test in the patch once I add the patch?
Comment 3 Gregg Tavares 2011-06-23 14:11:38 PDT 
Created attachment 98398 [details]
Patch
Comment 4 Kenneth Russell 2011-06-23 14:14:12 PDT 
(In reply to comment #2)
> done.
> 
> but wouldn't you see the test in the patch once I add the patch?

Sorry; yes, but in isolation this bug report was unclear. At minimum I would have mentioned the specific test in the bug description if not the title.
Comment 5 Kenneth Russell 2011-06-23 14:15:59 PDT 
Comment on attachment 98398 [details]
Patch

Looks fine. Do you want this submitted to the commit queue?
Comment 6 WebKit Review Bot 2011-06-23 15:19:33 PDT 
Comment on attachment 98398 [details]
Patch

Clearing flags on attachment: 98398

Committed r89626: <http://trac.webkit.org/changeset/89626>
Comment 7 WebKit Review Bot 2011-06-23 15:19:37 PDT 
All reviewed patches have been landed.  Closing bug.