Bug 63211

Summary: Make sheriff-bot robust against exceptions from commands
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, jamesr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Eric Seidel (no email)
Reported 2011-06-22 18:17:33 PDT
Make sheriff-bot robust against exceptions from commands
Attachments
Patch (4.64 KB, patch)
2011-06-22 18:18 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2011-06-22 18:18:08 PDT
Created attachment 98282 [details] Patch
Adam Barth
Comment 2 2011-06-22 18:21:27 PDT
Comment on attachment 98282 [details] Patch Looks great. Catching Exception is always scary, but this is probably the right thing to do.
WebKit Review Bot
Comment 3 2011-06-22 18:44:33 PDT
Comment on attachment 98282 [details] Patch Clearing flags on attachment: 98282 Committed r89518: <http://trac.webkit.org/changeset/89518>
WebKit Review Bot
Comment 4 2011-06-22 18:44:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.