Bug 63199

Summary:

new-run-webkit-tests: images page switch actual and expected images before they're loaded

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Tools / Tests

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dpranke, ojan, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

Attachments:

Description	Flags
Patch	none

Ryosuke Niwa

Reported 2011-06-22 16:12:06 PDT

Go to http://build.webkit.org/results/Chromium%20Mac%20Release%20(Tests)/r89486%20(8473)/fast/borders/border-radius-wide-border-01-diffs.html The script starts swapping images immediately even before images are loaded. This results in weird behavior where I see the same image for Actual and Expected because one of them haven't been loaded yet. We shouldn't switch between images until both images are loaded.

Attachments
Patch (3.50 KB, patch) 2011-06-29 18:48 PDT, Adam Barth	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Adam Barth

Comment 1 2011-06-29 18:48:21 PDT

Eric Seidel (no email)

Comment 2 2011-06-29 18:49:33 PDT

WebKit Review Bot

Comment 3 2011-06-29 19:30:15 PDT

Comment on attachment 99204 [details] Patch Clearing flags on attachment: 99204 Committed r90081: <http://trac.webkit.org/changeset/90081>

WebKit Review Bot

Comment 4 2011-06-29 19:30:20 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.