Bug 63199 - new-run-webkit-tests: images page switch actual and expected images before they're loaded
Summary: new-run-webkit-tests: images page switch actual and expected images before th...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 34984
  Show dependency treegraph
 
Reported: 2011-06-22 16:12 PDT by Ryosuke Niwa
Modified: 2011-06-29 19:30 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.50 KB, patch)
2011-06-29 18:48 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-06-22 16:12:06 PDT
Go to http://build.webkit.org/results/Chromium%20Mac%20Release%20(Tests)/r89486%20(8473)/fast/borders/border-radius-wide-border-01-diffs.html

The script starts swapping images immediately even before images are loaded.  This results in weird behavior where I see the same image for Actual and Expected because one of them haven't been loaded yet.

We shouldn't switch between images until both images are loaded.
Comment 1 Adam Barth 2011-06-29 18:48:21 PDT
Created attachment 99204 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-06-29 18:49:33 PDT
Comment on attachment 99204 [details]
Patch

OK.
Comment 3 WebKit Review Bot 2011-06-29 19:30:15 PDT
Comment on attachment 99204 [details]
Patch

Clearing flags on attachment: 99204

Committed r90081: <http://trac.webkit.org/changeset/90081>
Comment 4 WebKit Review Bot 2011-06-29 19:30:20 PDT
All reviewed patches have been landed.  Closing bug.