Bug 63198

Summary: Use create() method for AsyncAudioDecoder::DecodingTask
Product: WebKit Reporter: Chris Rogers <crogers>
Component: New BugsAssignee: Chris Rogers <crogers>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, levin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch levin: review+, levin: commit-queue-

Chris Rogers
Reported 2011-06-22 16:06:51 PDT
Use create() method for AsyncAudioDecoder
Attachments
Patch (3.12 KB, patch)
2011-06-22 16:10 PDT, Chris Rogers 		no flags
DetailsFormatted DiffDiff
Patch (3.03 KB, patch)
2011-06-22 16:41 PDT, Chris Rogers 		no flags
DetailsFormatted DiffDiff
Patch (3.53 KB, patch)
2011-06-22 16:52 PDT, Chris Rogers 		levin: review+
levin: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Rogers
Comment 1 2011-06-22 16:10:37 PDT
Created attachment 98259 [details] Patch
Chris Rogers
Comment 2 2011-06-22 16:11:34 PDT
This addresses a missed review comment by David Levin.
David Levin
Comment 3 2011-06-22 16:26:30 PDT
Comment on attachment 98259 [details] Patch Miscommunication.
Chris Rogers
Comment 4 2011-06-22 16:41:54 PDT
Created attachment 98264 [details] Patch
Chris Rogers
Comment 5 2011-06-22 16:44:01 PDT
sorry David, uploading one more patch with the create method implementation in the .cpp file
WebKit Review Bot
Comment 6 2011-06-22 16:46:09 PDT
Comment on attachment 98264 [details] Patch Attachment 98264 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8926722
David Levin
Comment 7 2011-06-22 16:47:15 PDT
Comment on attachment 98264 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98264&action=review Feel free to do your move to the cpp file on checkin (and the chromium build fix). > Source/WebCore/webaudio/AsyncAudioDecoder.h:56 > + static OwnPtr<DecodingTask> create(ArrayBuffer* audioData, double sampleRate, PassRefPtr<AudioBufferCallback> successCallback, PassRefPtr<AudioBufferCallback> errorCallback) Return type should be PassOwnPtr. (I thought we checked this, but if not, I'll add a style check quickly.)
Chris Rogers
Comment 8 2011-06-22 16:52:01 PDT
Created attachment 98265 [details] Patch
David Levin
Comment 9 2011-06-22 16:53:33 PDT
Comment on attachment 98265 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98265&action=review > Source/WebCore/webaudio/AsyncAudioDecoder.h:56 > + static OwnPtr<DecodingTask> create(ArrayBuffer* audioData, double sampleRate, PassRefPtr<AudioBufferCallback> successCallback, PassRefPtr<AudioBufferCallback> errorCallback); PassOwnPtr :) Filed bug https://bugs.webkit.org/show_bug.cgi?id=63204 (I'll have a patch up soon.)
Chris Rogers
Comment 10 2011-06-22 17:02:09 PDT
Committed r89499: <http://trac.webkit.org/changeset/89499>
Note You need to log in before you can comment on or make changes to this bug.