Bug 63174

Summary: Don't draw border as one path unless there really are 4 borders
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: Layout and RenderingAssignee: Beth Dakin <bdakin>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, simon.fraser
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch simon.fraser: review+

Beth Dakin
Reported 2011-06-22 13:05:17 PDT
Title says it all. If we DO draw the border as one path when there aren't really 4 borders, the accelerated drawing codepath can mis-render. Patch coming soon! <rdar://problem/9457997>
Attachments
Patch (25.62 KB, patch)
2011-06-22 13:23 PDT, Beth Dakin 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Beth Dakin
Comment 1 2011-06-22 13:23:16 PDT
Created attachment 98228 [details] Patch
Simon Fraser (smfr)
Comment 2 2011-06-22 13:27:12 PDT
Comment on attachment 98228 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98228&action=review > LayoutTests/fast/borders/only-one-border-with-width.html:13 > + border-right: 1px solid rgba(0, 0, 0, 0.15); Can you make it thicker so it's more obvious in the testcase? May also want to consider moving the text into an HTML comment to avoid spurious text diffs between platforms.
Beth Dakin
Comment 3 2011-06-22 13:29:35 PDT
(In reply to comment #2) > > Can you make it thicker so it's more obvious in the testcase? > Yes! Good call. > May also want to consider moving the text into an HTML comment to avoid spurious text diffs between platforms. Will do.
Beth Dakin
Comment 4 2011-06-22 13:45:20 PDT
Committed change with revision 89475.
Note You need to log in before you can comment on or make changes to this bug.