Summary: | IndexedDB: fix multiple issues in IDBDatabase.idl | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Pilgrim (Google) <pilgrim> | ||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, dgrogan, fishd, hans, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Mark Pilgrim (Google)
2011-06-22 07:59:04 PDT
Created attachment 98174 [details]
Patch
*** Bug 62414 has been marked as a duplicate of this bug. *** *** Bug 63117 has been marked as a duplicate of this bug. *** *** Bug 62415 has been marked as a duplicate of this bug. *** *** Bug 62416 has been marked as a duplicate of this bug. *** Comment on attachment 98174 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98174&action=review > Source/WebCore/storage/IDBDatabase.idl:58 > // EventTarget interface > void addEventListener(in DOMString type, > in EventListener listener, > - in boolean useCapture); > + in [Optional] boolean useCapture); > void removeEventListener(in DOMString type, > in EventListener listener, > - in boolean useCapture); > + in [Optional] boolean useCapture); There's some question about what the right thing here is globally, but I'm pretty sure this is what we're going to end up with. The only question is whether we want to make that decision all-at-once or whether we want to convert these piecemeal. I think it's ok to convert them piecemeal. Comment on attachment 98174 [details] Patch Clearing flags on attachment: 98174 Committed r89451: <http://trac.webkit.org/changeset/89451> All reviewed patches have been landed. Closing bug. |