Bug 63138

Summary: Web Inspector: split setAttributes and setAttributeValue.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch yurys: review+

Pavel Feldman
Reported 2011-06-22 07:23:49 PDT
setAttribute's documentation is confusing. It is actually doing a completely different thing.
Attachments
Patch (12.97 KB, patch)
2011-06-22 08:06 PDT, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-06-22 08:06:39 PDT
Created attachment 98173 [details] Patch
Yury Semikhatsky
Comment 2 2011-06-22 08:40:14 PDT
Comment on attachment 98173 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98173&action=review > Source/WebCore/inspector/Inspector.json:883 > + { "name": "text", "type": "string", "description": "Text with a number of attributes. Will parse this text using HTML parser." } We should be explicit about what should happen to the existing attributes with same names should the text contain such attributes.
Pavel Feldman
Comment 3 2011-06-22 09:25:10 PDT
Committed r89439: <http://trac.webkit.org/changeset/89439>
Note You need to log in before you can comment on or make changes to this bug.