Bug 63123 – run-webkit-websocketserver fails to stop websocket server

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Yuta Kitamura]

If you manually run run-webkit-websocketserver, it fails to stop the pywebsocket server and leaks the process. It's probably caused by r89400.

$ Tools/Scripts/run-webkit-websocketserver 
Starting Web Socket server...
Started.
Hit [ENTER] to stop it.
Stopping Web Socket server...
Traceback (most recent call last):
  File "/usr/local/google/home/yutak/build/Chromium/src/third_party/WebKit/Tools/Scripts/new-run-webkit-websocketserver", line 108, in <module>
    main()
  File "/usr/local/google/home/yutak/build/Chromium/src/third_party/WebKit/Tools/Scripts/new-run-webkit-websocketserver", line 105, in main
    pywebsocket.stop(force=True)
TypeError: stop() got an unexpected keyword argument 'force'
Stopped.

$ ps aux |grep pywebsocket
yutak    18693  0.0  0.0  48324  9548 pts/2    S    17:58   0:00 /usr/bin/python -u .../pywebsocket/mod_pywebsocket/standalone.py --server-host 127.0.0.1 --port 8880 ...
yutak    18788  0.0  0.0   6468   900 pts/2    S+   18:02   0:00 grep pywebsocket

[Dirk Pranke]

Created attachment 98212 [details]
patch that fixes new-run-webkit-websocketserver and also adds better tests

[Dirk Pranke]

I've fixed the bug that was causing new-run-webkit-websocketserver to crash, and revamped the integration tests so that we test that script as well as new-run-webkit-httpd .

The naming for the test class is pretty clumsy; I'm open to better ideas, but the important thing to preserve is that testing both scripts is basically identical so we should share the test code as much as possible.

[Dirk Pranke]

Created attachment 98217 [details]
fix rename, update ChangeLog

[Dirk Pranke]

Created attachment 98220 [details]
add dirname back in that was lost in the rename

[Dirk Pranke]

Committed r89459: <http://trac.webkit.org/changeset/89459>