Bug 63113

Summary: [Qt] Add a build flag for building with libxml2 and libxslt.
Product: WebKit Reporter: Yael <yael>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: annchriss234, ap, grannygames.com, kling, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch.
kling: review+, kling: commit-queue-
Patch. none

Yael
Reported 2011-06-21 20:17:59 PDT
QtWebKit should have a build option for building with libxml2 and libxslt instead of Qt's own libraries.
Attachments
Patch. (6.69 KB, patch)
2011-06-21 20:25 PDT, Yael 		kling: review+
kling: commit-queue-
DetailsFormatted DiffDiff
Patch. (6.74 KB, patch)
2011-06-22 17:19 PDT, Yael 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yael
Comment 1 2011-06-21 20:25:56 PDT
Created attachment 98110 [details] Patch. If this build flag was enabled by default, this would fix https://bugs.webkit.org/show_bug.cgi?id=55302 https://bugs.webkit.org/show_bug.cgi?id=37445 and xmlviewer tests could be unskipped.
Yael
Comment 2 2011-06-21 20:28:02 PDT
This patch assumes that enabling the flag WTF_USE_LIBXML2 automatically enables also ENABLE_XSLT, but it does not have to be that way.
Andreas Kling
Comment 3 2011-06-22 13:56:09 PDT
Comment on attachment 98110 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=98110&action=review > Source/WebCore/CodeGenerators.pri:28 > + Unnecessary newline! > Source/WebCore/features.pri:131 > > +contains(DEFINES, WTF_USE_LIBXML2=1) { Add a comment saying this is experimental and only works on Linux so far.
Yael
Comment 4 2011-06-22 17:19:37 PDT
Created attachment 98268 [details] Patch. Update with Kling's last comments.
WebKit Review Bot
Comment 5 2011-06-22 18:36:54 PDT
Comment on attachment 98268 [details] Patch. Clearing flags on attachment: 98268 Committed r89516: <http://trac.webkit.org/changeset/89516>
WebKit Review Bot
Comment 6 2011-06-22 18:36:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.