Bug 63107

Summary:

Make sheriff-bot rollout messages a little nicer

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

New Bugs

Assignee:

Eric Seidel (no email) <eric>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dbates, levin, mihaip, ojan, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Eric Seidel (no email)

Reported 2011-06-21 17:36:56 PDT

Make sheriff-bot rollout messages a little nicer

Attachments
Patch (14.48 KB, patch) 2011-06-21 17:44 PDT, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
Patch (1.56 KB, patch) 2011-06-22 18:24 PDT, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2011-06-21 17:44:05 PDT

Created attachment 98087 [details] Patch

Ojan Vafai

Comment 2 2011-06-21 18:50:35 PDT

Comment on attachment 98087 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98087&action=review > Tools/Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:82 > + # When folks pass junk arguments, we should just spit the usage back at them. This comment doesn't seem helpful. > Tools/Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:89 > + # FIXME: I'm slightly confused as to why this doesn't return the USAGE message. It's not clear from the USAGE message that you can't begin your rollout description with a dash.

Eric Seidel (no email)

Comment 3 2011-06-22 14:04:25 PDT

Comment on attachment 98087 [details] Patch Thank you for the review. I'm going to land it as is and iterate based on any further feedback from users.

WebKit Review Bot

Comment 4 2011-06-22 14:33:48 PDT

Comment on attachment 98087 [details] Patch Clearing flags on attachment: 98087 Committed r89480: <http://trac.webkit.org/changeset/89480>

WebKit Review Bot

Comment 5 2011-06-22 14:33:53 PDT

All reviewed patches have been landed. Closing bug.

David Levin

Comment 6 2011-06-22 18:18:15 PDT

This change is causing failures on Leopard bots (maybe because they use Python 2.5?): http://build.webkit.org/builders/Leopard%20Intel%20Debug%20%28Tests%29/builds/31597/steps/webkitpy-test/logs/stdio

Eric Seidel (no email)

Comment 7 2011-06-22 18:22:06 PDT

Sigh, yes from_iterable is new in 2.6: http://docs.python.org/library/itertools.html#itertools.chain.from_iterable

Eric Seidel (no email)

Comment 8 2011-06-22 18:22:55 PDT

Fixing now.

Eric Seidel (no email)

Comment 9 2011-06-22 18:24:38 PDT

Created attachment 98283 [details] Patch

Eric Seidel (no email)

Comment 10 2011-06-22 18:31:00 PDT

We need to make webkit-patch upload re-open patches when you attach a new patch. :(

WebKit Review Bot

Comment 11 2011-06-22 19:14:43 PDT

Comment on attachment 98283 [details] Patch Clearing flags on attachment: 98283 Committed r89520: <http://trac.webkit.org/changeset/89520>

WebKit Review Bot

Comment 12 2011-06-22 19:14:48 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.