Bug 63095

Summary: [Qt] Add an API for accessing the QGraphicsView.
Product: WebKit Reporter: Yael <yael>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch. kenneth: review+, kenneth: commit-queue-

Yael
Reported 2011-06-21 14:04:17 PDT
This was requested by 2 reviewers in https://bugs.webkit.org/show_bug.cgi?id=62838.
Attachments
Patch. (1.80 KB, patch)
2011-06-21 14:09 PDT, Yael 		kenneth: review+
kenneth: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yael
Comment 1 2011-06-21 14:09:05 PDT
Created attachment 98055 [details] Patch.
Kenneth Rohde Christiansen
Comment 2 2011-06-21 14:12:47 PDT
Comment on attachment 98055 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=98055&action=review > Source/WebKit2/ChangeLog:5 > + [Qt] Add an API for accessing the QGraphicsView. internal API* > Source/WebKit2/UIProcess/API/qt/qwkpage.cpp:316 > + if (views.size() > 1) > + qWarning("Cannot support multiple views"); Not sure this is the right way to handle it, but I guess it is fine.
Yael
Comment 3 2011-06-21 14:20:58 PDT
(In reply to comment #2) > (From update of attachment 98055 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=98055&action=review > > > Source/WebKit2/ChangeLog:5 > > + [Qt] Add an API for accessing the QGraphicsView. > > internal API* > > > Source/WebKit2/UIProcess/API/qt/qwkpage.cpp:316 > > + if (views.size() > 1) > > + qWarning("Cannot support multiple views"); > > Not sure this is the right way to handle it, but I guess it is fine. Thank you for reviewing :)
Yael
Comment 4 2011-06-21 14:34:13 PDT
Committed r89384: <http://trac.webkit.org/changeset/89384>
Note You need to log in before you can comment on or make changes to this bug.