Bug 63080

Summary: Unit-tests step on test-only bot is broken
Product: WebKit Reporter: Dmitry Lomov <dslomov>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, dslomov, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fix
none
Not disabling on build-and-test bots; disabling on non-(win and mac) none

Dmitry Lomov
Reported 2011-06-21 11:11:38 PDT
Removing the step until run-api-tests is fixed
Attachments
Fix (1.83 KB, patch)
2011-06-21 11:13 PDT, Dmitry Lomov 		no flags
DetailsFormatted DiffDiff
Not disabling on build-and-test bots; disabling on non-(win and mac) (1.80 KB, patch)
2011-06-21 11:53 PDT, Dmitry Lomov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dmitry Lomov
Comment 1 2011-06-21 11:13:25 PDT
Created attachment 98013 [details] Fix
Adam Roben (:aroben)
Comment 2 2011-06-21 11:46:25 PDT
Comment on attachment 98013 [details] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=98013&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:-564 > - # FIXME: Only running in debug mode due to https://bugs.webkit.org/show_bug.cgi?id=61812 > - if configuration == "debug": > - self.addStep(RunUnitTests) Presumably BuildAndTestFactory doesn't need this fix?
Adam Roben (:aroben)
Comment 3 2011-06-21 11:47:40 PDT
Comment on attachment 98013 [details] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=98013&action=review >> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:-564 >> - self.addStep(RunUnitTests) > > Presumably BuildAndTestFactory doesn't need this fix? Indeed, SnowLeopard Intel Leaks (which uses BuildAndTestFactory) doesn't show the issue you're trying to fix: http://build.webkit.org/builders/SnowLeopard%20Intel%20Leaks/builds/17616/steps/run-api-tests/logs/stdio
Dmitry Lomov
Comment 4 2011-06-21 11:48:39 PDT
(In reply to comment #3) > (From update of attachment 98013 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=98013&action=review > > >> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:-564 > >> - self.addStep(RunUnitTests) > > > > Presumably BuildAndTestFactory doesn't need this fix? > > Indeed, SnowLeopard Intel Leaks (which uses BuildAndTestFactory) doesn't show the issue you're trying to fix: http://build.webkit.org/builders/SnowLeopard%20Intel%20Leaks/builds/17616/steps/run-api-tests/logs/stdio Cool - I'll be back :)
Dmitry Lomov
Comment 5 2011-06-21 11:53:57 PDT
Created attachment 98030 [details] Not disabling on build-and-test bots; disabling on non-(win and mac)
Adam Roben (:aroben)
Comment 6 2011-06-21 12:08:53 PDT
Comment on attachment 98030 [details] Not disabling on build-and-test bots; disabling on non-(win and mac) View in context: https://bugs.webkit.org/attachment.cgi?id=98030&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:559 > + if configuration == "debug" and (platform == 'mac' or platform == 'win'): An even better way to write this is: if configuration == 'debug' and platform in ('mac', 'win'):
WebKit Review Bot
Comment 7 2011-06-21 12:58:50 PDT
Comment on attachment 98030 [details] Not disabling on build-and-test bots; disabling on non-(win and mac) Clearing flags on attachment: 98030 Committed r89373: <http://trac.webkit.org/changeset/89373>
WebKit Review Bot
Comment 8 2011-06-21 12:58:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.