Bug 63047

Summary: [GTK] Switch to GTK+ 3.x by default
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo.noronha, gustavo, mrobinson, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on:    
Bug Blocks: 62749    
Attachments:
Description Flags
Patch xan.lopez: review+, gustavo.noronha: commit-queue-

Carlos Garcia Campos
Reported 2011-06-20 23:55:01 PDT
A lot of layout tests give slightly different results with gtk3, so it requires new test results too.
Attachments
Patch (1.29 KB, patch)
2011-06-24 15:30 PDT, Martin Robinson 		xan.lopez: review+
gustavo.noronha: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2011-06-24 15:30:37 PDT
Created attachment 98552 [details] Patch
Martin Robinson
Comment 2 2011-06-24 16:20:23 PDT
I will take care of updating the expected results when landing this patch.
Collabora GTK+ EWS bot
Comment 3 2011-06-24 18:37:09 PDT
Comment on attachment 98552 [details] Patch Attachment 98552 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/8935577
Gustavo Noronha (kov)
Comment 4 2011-07-11 08:00:56 PDT
I installed GTK+ 3 and gail 3 on the EWS now, and will do on the 32bits buildbot in a second, so future versions of this patch should pass and when it's landed it should build fine on the release buildbot. I think it'd be good to make this switch soon, just let me know when you're planning to and we'll coordinate. The versions I'm installing: libgtk-3-dev and libgail-3-dev 3.0.10-1
Xan Lopez
Comment 5 2011-08-23 09:27:58 PDT
Comment on attachment 98552 [details] Patch After careful deliberation I believe this patch to be correct.
Martin Robinson
Comment 6 2011-08-25 22:35:33 PDT
Committed r93852: <http://trac.webkit.org/changeset/93852>
Note You need to log in before you can comment on or make changes to this bug.