Bug 63016

Summary: New test for patch introduced in r89250
Product: WebKit Reporter: Stephen White <senorblanco>
Component: New BugsAssignee: Stephen White <senorblanco>
Status: RESOLVED FIXED    
Severity: Normal CC: jamesr, kbr, reed
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Make pixel test more lenient so it passes on mac jamesr: review+

Stephen White
Reported 2011-06-20 14:51:41 PDT
New test for patch introduced in r89250
Attachments
Patch (2.94 KB, patch)
2011-06-20 14:52 PDT, Stephen White 		no flags
DetailsFormatted DiffDiff
Make pixel test more lenient so it passes on mac (2.99 KB, patch)
2011-06-20 15:48 PDT, Stephen White 		jamesr: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Stephen White
Comment 1 2011-06-20 14:52:50 PDT
Created attachment 97860 [details] Patch
Stephen White
Comment 2 2011-06-20 15:48:59 PDT
Created attachment 97876 [details] Make pixel test more lenient so it passes on mac
James Robinson
Comment 3 2011-06-20 16:39:48 PDT
Comment on attachment 97876 [details] Make pixel test more lenient so it passes on mac R=me
Alexey Proskuryakov
Comment 4 2011-06-20 20:50:09 PDT
Comment on attachment 97876 [details] Make pixel test more lenient so it passes on mac View in context: https://bugs.webkit.org/attachment.cgi?id=97876&action=review > LayoutTests/ChangeLog:10 > + * fast/canvas/script-tests/text-globalAlpha.js: Added. > + * fast/canvas/text-globalAlpha-expected.txt: Added. > + * fast/canvas/text-globalAlpha.html: Added. Please avoid splitting tests into multiple files.
James Robinson
Comment 5 2011-06-20 22:08:13 PDT
That's the standard way of doing script tests.
Stephen White
Comment 6 2011-06-21 06:48:59 PDT
> (From update of attachment 97876 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=97876&action=review > > > LayoutTests/ChangeLog:10 > > + * fast/canvas/script-tests/text-globalAlpha.js: Added. > > + * fast/canvas/text-globalAlpha-expected.txt: Added. > > + * fast/canvas/text-globalAlpha.html: Added. > > Please avoid splitting tests into multiple files. (In reply to comment #5) > That's the standard way of doing script tests. Yes, I based it off existing tests. That said, the HTML is fairly boilerplate between these script tests, differing only in the line which pulls in the JS. I wonder if there's a way to share more code.
Stephen White
Comment 7 2011-06-21 06:50:12 PDT
Committed r89351: <http://trac.webkit.org/changeset/89351>
Note You need to log in before you can comment on or make changes to this bug.