Bug 63012

Summary: HTTP pipelining functions on mac should match windows
Product: WebKit Reporter: Pratik Solanki <psolanki>
Component: PlatformAssignee: Pratik Solanki <psolanki>
Status: RESOLVED FIXED    
Severity: Normal CC: ddkilzer, koivisto, psolanki
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ddkilzer: review+

Pratik Solanki
Reported 2011-06-20 14:24:38 PDT
The definitions for pipelining functions (WKGetHTTPPipeliningPriority and WKSetHTTPPipeliningPriority) take an NSURLRequest on Mac and a CFURLRequest on Windows. We should match the 2 and just use CFURLRequestRef on Mac. This will help bug 51836.
Attachments
Patch (760.26 KB, patch)
2011-06-20 15:03 PDT, Pratik Solanki 		ddkilzer: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pratik Solanki
Comment 1 2011-06-20 15:03:10 PDT
Created attachment 97866 [details] Patch
David Kilzer (:ddkilzer)
Comment 2 2011-06-20 15:23:48 PDT
Comment on attachment 97866 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97866&action=review r=me > Source/WebCore/platform/mac/WebCoreSystemInterface.h:195 > -extern void (*wkSetHTTPPipeliningPriority)(NSMutableURLRequest *, int priority); > +extern void (*wkSetHTTPPipeliningPriority)(CFURLRequestRef, int priority); Thank you for cleaning that up for me. :)
Pratik Solanki
Comment 3 2011-06-20 15:46:05 PDT
Committed r89300: <http://trac.webkit.org/changeset/89300>
Note You need to log in before you can comment on or make changes to this bug.