Bug 62988

Summary: [Skia] remove repeated calls to setColor, which ignored global-alpha (previous setupPaintFor... already set the color+alpha)
Product: WebKit Reporter: Mike Reed <reed>
Component: New BugsAssignee: Mike Reed <reed>
Status: RESOLVED FIXED    
Severity: Normal CC: senorblanco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch senorblanco: review-

Mike Reed
Reported 2011-06-20 07:41:59 PDT
[Skia] remove repeated calls to setColor, which ignored global-alpha (previous setupPaintFor... already set the color+alpha)
Attachments
Patch (1.98 KB, patch)
2011-06-20 07:43 PDT, Mike Reed 		no flags
DetailsFormatted DiffDiff
Patch (3.41 KB, patch)
2011-06-20 09:39 PDT, Mike Reed 		senorblanco: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mike Reed
Comment 1 2011-06-20 07:43:49 PDT
Created attachment 97799 [details] Patch
Stephen White
Comment 2 2011-06-20 08:28:59 PDT
Comment on attachment 97799 [details] Patch Looks good. r=me Does this affect any tests? Or only the one previously suppressed?
Mike Reed
Comment 3 2011-06-20 08:34:10 PDT
this is not related to the previous suppression. It came out of some comments from Eric S. related to redundant code in this file. I have another bug to try to fix more of those separately. https://bugs.webkit.org/show_bug.cgi?id=62989
WebKit Review Bot
Comment 4 2011-06-20 09:37:58 PDT
Comment on attachment 97799 [details] Patch Clearing flags on attachment: 97799 Committed r89250: <http://trac.webkit.org/changeset/89250>
WebKit Review Bot
Comment 5 2011-06-20 09:38:02 PDT
All reviewed patches have been landed. Closing bug.
Mike Reed
Comment 6 2011-06-20 09:39:14 PDT
Created attachment 97812 [details] Patch
Stephen White
Comment 7 2011-06-20 10:24:49 PDT
Comment on attachment 97812 [details] Patch Thanks, I'll take what you have here and try to turn it into a script-test (so it doesn't require pixel results).
Note You need to log in before you can comment on or make changes to this bug.