Summary: | [EFL] ChromeClientEfl doesn't need to check whether m_view is null. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryuan Choi <ryuan.choi> | ||||||
Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | gyuyoung.kim, kenneth, leandro, lucas.de.marchi, rakuco, tonikitoo, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Ryuan Choi
2011-06-20 05:03:47 PDT
Created attachment 97895 [details]
Patch
Comment on attachment 97895 [details]
Patch
Should not you have ASSERTs instead then?
Created attachment 97898 [details]
Patch
(In reply to comment #2) > (From update of attachment 97895 [details]) > Should not you have ASSERTs instead then? Thanks for your comment. m_view is only changed When called constructor of ChromeClientEfl. Does we need to add ASSERT before calling m_view every time? Almost other methods of ChromeClientEfl use m_view without checking m_view. The commit-queue encountered the following flaky tests while processing attachment 97898 [details]: http/tests/local/formdata/send-form-data.html bug 63034 (author: jianli@chromium.org) The commit-queue is continuing to process your patch. Comment on attachment 97898 [details] Patch Clearing flags on attachment: 97898 Committed r89327: <http://trac.webkit.org/changeset/89327> All reviewed patches have been landed. Closing bug. |