Bug 6297

Summary: XMLSerializer should use createMarkup
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: DOMAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Fix some bugs in createMarkup, and make xmlserializer use it eric: review+

Anders Carlsson
Reported 2005-12-30 00:14:55 PST
Since we're trying to get rid of NodeImpl::toString, we should use createMarkup in XMLSerializer
Attachments
Fix some bugs in createMarkup, and make xmlserializer use it (9.36 KB, patch)
2005-12-30 01:52 PST, Anders Carlsson 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2005-12-30 01:52:47 PST
Created attachment 5375 [details] Fix some bugs in createMarkup, and make xmlserializer use it
Eric Seidel (no email)
Comment 2 2005-12-30 02:05:29 PST
Comment on attachment 5375 [details] Fix some bugs in createMarkup, and make xmlserializer use it We talked about this on irc. You were going to rename escapeHTML to something like escapeTextForMarkup when landing. Also, I'm not 100% convinced that we really have enough XMLSerializer tests to know that this change won't break anything. Finally, this might have changed one more test case xsltprocessor.html which should be testing for a document fragment containing only a text node (6180 I think?). Assuming you feel the test cases are sufficent, r=me. Thanks for another great patch!
Lucas Forschler
Comment 3 2019-02-06 09:03:15 PST
Mass moving XML DOM bugs to the "DOM" Component.
Note You need to log in before you can comment on or make changes to this bug.