Bug 62941

Summary: Git.push_local_commits_to_server() should use passed username and password when we don't have cached credentials
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dominicc, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch and unit tests none

Daniel Bates
Reported 2011-06-18 15:49:08 PDT
Following up on Dominic Cooney's comment <https://bugs.webkit.org/show_bug.cgi?id=31500#c39>, Git.push_local_commits_to_server should only raise an AuthenticationError exception when "(not username or not password) and not self.has_authorization_for_realm(SVN.svn_server_realm)". Otherwise, we'll eventually prompt for a username and password but never actually use it.
Attachments
Patch and unit tests (3.36 KB, patch)
2011-06-18 17:28 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2011-06-18 17:27:15 PDT
When writing unit tests for this I ran into a issue with SCM.find_checkout_root(). See <https://bugs.webkit.org/show_bug.cgi?id=62945#c1> for more details.
Daniel Bates
Comment 2 2011-06-18 17:28:42 PDT
Created attachment 97711 [details] Patch and unit tests We'll need to fix bug #62945 in order for the unit tests to run.
Eric Seidel (no email)
Comment 3 2011-06-18 18:06:24 PDT
Comment on attachment 97711 [details] Patch and unit tests LGTM.
WebKit Review Bot
Comment 4 2011-06-18 18:55:37 PDT
Comment on attachment 97711 [details] Patch and unit tests Clearing flags on attachment: 97711 Committed r89209: <http://trac.webkit.org/changeset/89209>
WebKit Review Bot
Comment 5 2011-06-18 18:55:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.