Summary: | Git.push_local_commits_to_server() should use passed username and password when we don't have cached credentials | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||
Component: | Tools / Tests | Assignee: | Daniel Bates <dbates> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, dominicc, eric, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Daniel Bates
2011-06-18 15:49:08 PDT
When writing unit tests for this I ran into a issue with SCM.find_checkout_root(). See <https://bugs.webkit.org/show_bug.cgi?id=62945#c1> for more details. Created attachment 97711 [details] Patch and unit tests We'll need to fix bug #62945 in order for the unit tests to run. Comment on attachment 97711 [details]
Patch and unit tests
LGTM.
Comment on attachment 97711 [details] Patch and unit tests Clearing flags on attachment: 97711 Committed r89209: <http://trac.webkit.org/changeset/89209> All reviewed patches have been landed. Closing bug. |