Bug 62933

Summary: Various editing functions take boolean userTriggered but should be replaced by an enum
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, darin, enrica, eric, ojan, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
cleanup darin: review+

Ryosuke Niwa
Reported 2011-06-18 11:16:41 PDT
Quite few editing functions take boolean userTriggered argument. We should replace it by an enum.
Attachments
cleanup (40.28 KB, patch)
2011-06-20 13:10 PDT, Ryosuke Niwa 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2011-06-20 13:10:58 PDT
Created attachment 97844 [details] cleanup
Eric Seidel (no email)
Comment 2 2011-06-20 13:13:05 PDT
Does this need to be FrameSelection::UserTrigggered? or can we have it be global?
Darin Adler
Comment 3 2011-06-20 13:15:49 PDT
Comment on attachment 97844 [details] cleanup Does the enum really need to be a member of FrameSelection? Can’t it be a namespace-level enum?
Darin Adler
Comment 4 2011-06-20 13:16:42 PDT
Heh, Eric and I said the same thing, but I didn’t read his comment until after I posted mine.
Ryosuke Niwa
Comment 5 2011-06-20 13:18:50 PDT
Thank for the review. I'll move EUserTriggered out of FrameSelection.
Ryosuke Niwa
Comment 6 2011-06-20 15:03:33 PDT
Committed r89293: <http://trac.webkit.org/changeset/89293>
Ryosuke Niwa
Comment 7 2011-06-20 15:38:13 PDT
EFL WinCE build fixes: http://trac.webkit.org/changeset/89298 Bit flag collision fix: http://trac.webkit.org/changeset/89299
Note You need to log in before you can comment on or make changes to this bug.