Bug 62932

Summary:

FrameSelection::modify should take verticalDisplacement instead of verticalDistance

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

HTML Editing

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, enrica, eric, morrita, ojan, tkent, tony, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
renamed the argument	none
added VerticalDirection enum	none

Description Ryosuke Niwa 2011-06-18 11:13:23 PDT

A distance is the magnitude of a displacement.  We shouldn't be using these terms interchangeably.

Comment 1 Ryosuke Niwa 2011-06-20 09:58:32 PDT

Created attachment 97816 [details]
renamed the argument

Comment 2 Ryosuke Niwa 2011-06-20 10:03:30 PDT

Comment on attachment 97816 [details]
renamed the argument

On my second thought, it's probably cleaner to add VerticalDirection enum because callers compute distance and then pass distance or -distance depending.

Comment 3 Ryosuke Niwa 2011-06-20 10:31:49 PDT

Created attachment 97822 [details]
added VerticalDirection enum

Comment 4 WebKit Review Bot 2011-06-20 11:29:01 PDT

Comment on attachment 97822 [details]
added VerticalDirection enum

Clearing flags on attachment: 97822

Committed r89263: <http://trac.webkit.org/changeset/89263>

Comment 5 WebKit Review Bot 2011-06-20 11:29:06 PDT

All reviewed patches have been landed.  Closing bug.

Comment 6 Ryosuke Niwa 2011-06-20 11:33:51 PDT

Thanks for the review, Ojan.  More bool shaving patches are coming!