Bug 62903

Summary: remove references to dump-as-markup in editing/deleting/delete-by-word tests
Product: WebKit Reporter: Wyatt Carss <wcarss>
Component: HTML EditingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement CC: rniwa, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
URL: http://trac.webkit.org/browser/trunk/LayoutTests/editing/deleting/delete-by-word-001.html
Attachments:
Description Flags
Patch
none
Patch none

Wyatt Carss
Reported 2011-06-17 12:57:12 PDT
fixed broken references in editing/deleting/delete-by-word tests
Attachments
Patch (1.88 KB, patch)
2011-06-17 12:59 PDT, Wyatt Carss 		no flags
DetailsFormatted DiffDiff
Patch (1.89 KB, patch)
2011-06-20 13:58 PDT, Wyatt Carss 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wyatt Carss
Comment 1 2011-06-17 12:59:30 PDT
Created attachment 97640 [details] Patch
Ryosuke Niwa
Comment 2 2011-06-17 13:16:40 PDT
Comment on attachment 97640 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97640&action=review > LayoutTests/ChangeLog:5 > + fixed broken references in editing/deleting/delete-by-word tests Please update the bug title.
Wyatt Carss
Comment 3 2011-06-17 17:46:40 PDT
Updated!
Ryosuke Niwa
Comment 4 2011-06-17 17:51:58 PDT
(In reply to comment #3) > Updated! Oh, that's not what I meant. I meant that you should update the bug title in the change log. The bug shouldn't say you fixed something because that's what a patch does. Since you're removing references to dump-as-markup.js in this patch, you should either say that or say that those tests include dum-as-markup.js needlessly.
Wyatt Carss
Comment 5 2011-06-20 13:58:41 PDT
Created attachment 97855 [details] Patch
WebKit Review Bot
Comment 6 2011-06-22 19:59:50 PDT
Comment on attachment 97855 [details] Patch Rejecting attachment 97855 [details] from commit-queue. wcarss@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
Ryosuke Niwa
Comment 7 2011-06-22 20:37:14 PDT
You can't add cq+ yourself. That's committer's privilege.
WebKit Review Bot
Comment 8 2011-06-23 10:36:11 PDT
Comment on attachment 97855 [details] Patch Clearing flags on attachment: 97855 Committed r89585: <http://trac.webkit.org/changeset/89585>
WebKit Review Bot
Comment 9 2011-06-23 10:36:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.