fixed broken references in editing/deleting/delete-by-word tests
Created attachment 97640 [details] Patch
Comment on attachment 97640 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97640&action=review > LayoutTests/ChangeLog:5 > + fixed broken references in editing/deleting/delete-by-word tests Please update the bug title.
Updated!
(In reply to comment #3) > Updated! Oh, that's not what I meant. I meant that you should update the bug title in the change log. The bug shouldn't say you fixed something because that's what a patch does. Since you're removing references to dump-as-markup.js in this patch, you should either say that or say that those tests include dum-as-markup.js needlessly.
Created attachment 97855 [details] Patch
Comment on attachment 97855 [details] Patch Rejecting attachment 97855 [details] from commit-queue. wcarss@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
You can't add cq+ yourself. That's committer's privilege.
Comment on attachment 97855 [details] Patch Clearing flags on attachment: 97855 Committed r89585: <http://trac.webkit.org/changeset/89585>
All reviewed patches have been landed. Closing bug.