Bug 62903 - remove references to dump-as-markup in editing/deleting/delete-by-word tests
Summary: remove references to dump-as-markup in editing/deleting/delete-by-word tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Nobody
URL: http://trac.webkit.org/browser/trunk/...
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-17 12:57 PDT by Wyatt Carss
Modified: 2011-06-23 10:36 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.88 KB, patch)
2011-06-17 12:59 PDT, Wyatt Carss
no flags Details | Formatted Diff | Diff
Patch (1.89 KB, patch)
2011-06-20 13:58 PDT, Wyatt Carss
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wyatt Carss 2011-06-17 12:57:12 PDT
fixed broken references in editing/deleting/delete-by-word tests
Comment 1 Wyatt Carss 2011-06-17 12:59:30 PDT
Created attachment 97640 [details]
Patch
Comment 2 Ryosuke Niwa 2011-06-17 13:16:40 PDT
Comment on attachment 97640 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97640&action=review

> LayoutTests/ChangeLog:5
> +        fixed broken references in editing/deleting/delete-by-word tests

Please update the bug title.
Comment 3 Wyatt Carss 2011-06-17 17:46:40 PDT
Updated!
Comment 4 Ryosuke Niwa 2011-06-17 17:51:58 PDT
(In reply to comment #3)
> Updated!

Oh, that's not what I meant.  I meant that you should update the bug title in the change log.  The bug shouldn't say you fixed something because that's what a patch does.  Since you're removing references to dump-as-markup.js in this patch, you should either say that or say that those tests include dum-as-markup.js needlessly.
Comment 5 Wyatt Carss 2011-06-20 13:58:41 PDT
Created attachment 97855 [details]
Patch
Comment 6 WebKit Review Bot 2011-06-22 19:59:50 PDT
Comment on attachment 97855 [details]
Patch

Rejecting attachment 97855 [details] from commit-queue.

wcarss@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 7 Ryosuke Niwa 2011-06-22 20:37:14 PDT
You can't add cq+ yourself.  That's committer's privilege.
Comment 8 WebKit Review Bot 2011-06-23 10:36:11 PDT
Comment on attachment 97855 [details]
Patch

Clearing flags on attachment: 97855

Committed r89585: <http://trac.webkit.org/changeset/89585>
Comment 9 WebKit Review Bot 2011-06-23 10:36:15 PDT
All reviewed patches have been landed.  Closing bug.