Summary: | Expand Web Worker test coverage for onerror to have test for url/line numbers. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Levin <levin> | ||||
Component: | DOM | Assignee: | David Levin <levin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, dimich | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
David Levin
2011-06-17 12:02:46 PDT
Created attachment 97853 [details]
Patch
Comment on attachment 97853 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97853&action=review r=me with a nit: > LayoutTests/fast/workers/resources/worker-script-error-bubbled.js:7 > return true; There is unbalanced ' in the output this line produces. (In reply to comment #2) > (From update of attachment 97853 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=97853&action=review > > r=me with a nit: > > > LayoutTests/fast/workers/resources/worker-script-error-bubbled.js:7 > > return true; > > There is unbalanced ' in the output this line produces. I don't see it. Perhaps one issue is that both the worker and the main page use ' to quote which is confusing. I could switch the quotes in the main page to be "" for this message. (In reply to comment #3) > > There is unbalanced ' in the output this line produces. > > I don't see it. Perhaps one issue is that both the worker and the main page use ' to quote which is confusing. I don't see it now as well. Please disregard my comment. Perhaps indeed using " for main page could be less confusing. Committed as http://trac.webkit.org/changeset/89291. |