Bug 62877

Summary: [EFL] Add OwnPtr specializations for EFL types.
Product: WebKit Reporter: Raphael Kubo da Costa (:rakuco) <rakuco>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, leandro, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 61942, 61974, 62034    
Attachments:
Description Flags
Patch none

Raphael Kubo da Costa (:rakuco)
Reported 2011-06-17 10:35:13 PDT
[EFL] Add OwnPtr specializations for EFL types.
Attachments
Patch (4.33 KB, patch)
2011-06-17 10:46 PDT, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Raphael Kubo da Costa (:rakuco)
Comment 1 2011-06-17 10:46:33 PDT
Created attachment 97617 [details] Patch
Raphael Kubo da Costa (:rakuco)
Comment 2 2011-06-17 10:48:58 PDT
These specializations are needed for us to upstream EFL's DumpRenderTree, as Eric has been very clear that we should not be doing manual memory management in the code. The style bot will complain about some struct names, but they are false positives.
Eric Seidel (no email)
Comment 3 2011-06-17 10:50:06 PDT
Comment on attachment 97617 [details] Patch FANTASTIC. This is the right approach, thank you.
WebKit Review Bot
Comment 4 2011-06-17 10:50:46 PDT
Attachment 97617 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/wtf/OwnPtrCommon.h:54: Ecore_Evas is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/wtf/OwnPtrCommon.h:55: Evas_Object is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Review Bot
Comment 5 2011-06-17 11:58:43 PDT
Comment on attachment 97617 [details] Patch Clearing flags on attachment: 97617 Committed r89153: <http://trac.webkit.org/changeset/89153>
WebKit Review Bot
Comment 6 2011-06-17 11:58:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.