Bug 6283

Summary: abstract frame traversal in WebFrame more
Product: WebKit Reporter: Maciej Stachowiak <mjs>
Component: WebKit APIAssignee: Maciej Stachowiak <mjs>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
the patch darin: review+

Maciej Stachowiak
Reported 2005-12-29 04:27:29 PST
I rewrote most of the frame traversal code in WebFrame to use DOM-style first/last/next/previous methods, to abstract access better in preparation for moving it down. As an added bonus, many formerly recursive methods are now iterative. Patch coming shortly.
Attachments
the patch (30.25 KB, patch)
2005-12-29 04:36 PST, Maciej Stachowiak 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Maciej Stachowiak
Comment 1 2005-12-29 04:36:51 PST
Created attachment 5350 [details] the patch
Darin Adler
Comment 2 2005-12-29 08:56:52 PST
Comment on attachment 5350 [details] the patch _closeOldDataSources now works from the first child to the last, but it used to work from the last child to the first. Looks fine, r=me.
Maciej Stachowiak
Comment 3 2005-12-29 15:40:06 PST
I don't think the order is important since all it does is send a delegate message
Note You need to log in before you can comment on or make changes to this bug.